Don't default to permanent if falsy permitType

[ChinemeremChigbo]

The permit type field should never be falsy, but at times javascript eludes understanding

Notion ticket link

[16] For new temporary permit holders, under their Past APPs section, it lists them as having a permanent permit despite their recent permit request being a temporary one

Implementation description

• I have still been unable to replicate this bug on my end, however I think it may be worth asking rcd if this change has any effect on their end.

Checklist

• My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
• I have run the appropriate linter(s)
• I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

[sherryhli]

but at times JavaScript eludes understanding

😂

@ChinemeremChigbo one thought, I think this may be related to #273, another of the unreleased fixes. If permit type was previously not queried from the backend, then it would be defaulting to PERMANENT on the frontend

[ChinemeremChigbo]

but at times JavaScript eludes understanding

😂

@ChinemeremChigbo one thought, I think this may be related to #273, another of the unreleased fixes. If permit type was previously not queried from the backend, then it would be defaulting to PERMANENT on the frontend

Ahh interesting, should I close this PR then? I don't think that this permitType should ever be falsy, so I don't really think this change will make any difference.

[sherryhli]

@ChinemeremChigbo Yeah let's close it. It seems #273 was indeed the fix based on RCD's latest email.