Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Build Pagination component #33

Merged
merged 2 commits into from
Jul 23, 2021

Conversation

OustanDing
Copy link
Member

@OustanDing OustanDing commented Jul 23, 2021

Notion ticket link

Ticket

Implementation description

  • Built Pagination component for handling pagination of Table components. Pagination is handled server-side, so GQL data refetching should be done in the onPageChange callback parameter
  • Added Pagination component to Requests table page
    image

Notes

  • The original ticket required many fields that I realized were unnecessary, as the functionality could be abstracted in the Pagination component
  • The usePagination hook is not necessary - again, all of the functionality could be abstracted inside the Pagination component

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@OustanDing OustanDing added the needs dev review Needs dev review label Jul 23, 2021
@OustanDing OustanDing requested a review from a team July 23, 2021 01:18
@railway-app
Copy link

railway-app bot commented Jul 23, 2021

This PR is being deployed to Railway 🚅

Live → richmond-centre-for-disability-pr-33.up.railway.app

[View Deployment]

@OustanDing OustanDing merged commit 4a58f98 into staging Jul 23, 2021
@OustanDing OustanDing deleted the od/feature/build-table-pagination-component branch July 23, 2021 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs dev review Needs dev review
Projects
None yet
2 participants