Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Change address from unit 842 to 968 #361

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

leogjhuang
Copy link
Collaborator

@leogjhuang leogjhuang commented Jun 7, 2024

Notion ticket link

New Address

Implementation description

Testing plan

  1. Follow request approval flow.
  2. Verify the generated invoice and donation receipt PDF has the new address.

The steps are outlined in the video below:

add-receipt-numbers-2.mp4

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@leogjhuang leogjhuang self-assigned this Jun 7, 2024
Copy link
Member

@ChinemeremChigbo ChinemeremChigbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leogjhuang leogjhuang merged commit 6cb9611 into staging Jun 21, 2024
1 check passed
@leogjhuang leogjhuang deleted the lh/new-address branch June 21, 2024 02:04
leogjhuang added a commit that referenced this pull request Jun 21, 2024
leogjhuang added a commit that referenced this pull request Jun 21, 2024
* Add Sharujan to employees.ts (#360)

* [Improvement] Add Mail Lost Option as Replacement Reason (#340)

* initial commit for the mail lost option

* changed the processing fee for mail lost

* made the migrations for mail lost

* reverted yarn lock to staging

* initial commit for the mail lost option

* changed the processing fee for mail lost

* made the migrations for mail lost

* reverted yarn lock to staging

---------

Co-authored-by: Chinemerem <chinemeremchigbo@Outlook.com>

* Add $200 donation option (#355)

* Add $200 donation option

* Add $200 donation option

* Update .env.sample with $200 donation product id

---------

Co-authored-by: Chinemerem <chinemeremchigbo@Outlook.com>

* Change address from unit 842 to 968 (#361)

* [Fix] Add AMEX as a second payment option (#362)

* [Feature] Add receipt numbers to application reports (#363)

* [Misc] Update README.md (#364)

---------

Co-authored-by: Chinemerem <chinemeremchigbo@Outlook.com>
Co-authored-by: Keane Moraes <lordvader3002@gmail.com>
Co-authored-by: Sherry Li <sherryhli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants