Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Fixed button layout on landing page, added favicon, added underline on hover for ghost variant buttons #43

Merged
merged 7 commits into from
Aug 6, 2021
Merged

[Misc] Fixed button layout on landing page, added favicon, added underline on hover for ghost variant buttons #43

merged 7 commits into from
Aug 6, 2021

Conversation

chrischan325
Copy link
Contributor

Notion ticket link

Fix layout of buttons on landing page
Add favicon
Add underline on hover to links in Button ghost variant

Implementation description

  • Switched places of two buttons outlined in the diagram of the ticket
  • Added link tag in the head of the Layout component to add the favicon
  • Went into button.ts to added the underline style in the _hover section

Notes

Checklist

  • [x ] My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • [x ] I have run the appropriate linter(s)
  • [x ] I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@railway-app
Copy link

railway-app bot commented Aug 3, 2021 •
edited
Loading

This PR is being deployed to Railway 🚅

Live → richmond-centre-for-disability-pr-43.up.railway.app

[View Deployment]

@chrischan325 chrischan325 force-pushed the cc/fix-buttons-add-favicon-ghost-variant-button branch from 6e4a60e to 5479fcf Compare August 3, 2021 01:00
@chrischan325 chrischan325 changed the title Cc/fix buttons add favicon ghost variant button [Fix][Improvement][Feature] Fixed button layout on landing page, added favicon, added underline on hover for ghost variant buttons Aug 4, 2021
@OustanDing OustanDing changed the title [Fix][Improvement][Feature] Fixed button layout on landing page, added favicon, added underline on hover for ghost variant buttons [Misc] Fixed button layout on landing page, added favicon, added underline on hover for ghost variant buttons Aug 4, 2021
OustanDing
OustanDing requested changes Aug 5, 2021
View reviewed changes
Copy link
Member

@OustanDing OustanDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small things. Otherwise looks pretty good!

pages/index.tsx Outdated Show resolved Hide resolved
pages/index.tsx Outdated Show resolved Hide resolved
tools/theme/components/button.ts Outdated Show resolved Hide resolved
@OustanDing OustanDing added the don't merge Do not merge label Aug 5, 2021
@chrischan325 chrischan325 added needs dev review Needs dev review and removed don't merge Do not merge labels Aug 5, 2021
OustanDing
OustanDing approved these changes Aug 6, 2021
View reviewed changes
Copy link
Member

@OustanDing OustanDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrischan325 chrischan325 merged commit ce6d153 into staging Aug 6, 2021
@chrischan325 chrischan325 deleted the cc/fix-buttons-add-favicon-ghost-variant-button branch August 6, 2021 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OustanDing OustanDing OustanDing approved these changes

Assignees
No one assigned
Labels
needs dev review Needs dev review
Projects
None yet
Milestone
No milestone
2 participants
@chrischan325 @OustanDing