[Feature] View Permit Holder API hookup #50

j-bunk · 2021-08-18T00:03:46Z

Notion ticket link

View + Edit Permit Holder API hookup

Implementation description

General TODO list:

EditUserInformationModal API hookup
EditDoctorInformationModal API hookup
applicantApplicationProcessingHistoryResolver field resolver
Overall page hookup and passing relevant data down to the cards
Other (handling dynamic route, addressing some notes from the Notion ticket etc.)

Notes

Checklist

My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
I have run the appropriate linter(s)
I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

components/permit-holders/modals/EditUserInformationModal.tsx

j-bunk · 2021-08-18T02:58:19Z

prisma/schema.sql

@@ -71,10 +71,10 @@ CREATE TABLE physicians (
  address_line_1  VARCHAR(255) NOT NULL,
  address_line_2  VARCHAR(255),
  city            VARCHAR(255) NOT NULL,
-  province        Province NOT NULL,
+  province        Province NOT NULL DEFAULT 'BC',


Upserting a physician was failing because province and status are not specified in EditDoctorInformationModal so I added default values to db. The default values could have also been specified somewhere else instead but I think BC and ACTIVE are sensible defaults to have on the database level so we don't have to specify these values every time we handle physician creation

j-bunk · 2021-08-18T03:27:53Z

components/permit-holders/modals/MedicalHistoryModal.tsx

              </Box>
            )}

-            {medicalInformation.notes && (
+            {application.notes && (


I think application.notes isn't correct here as I believe this refers to notes on the application itself and not notes relating to medical information but I kept it here as a placeholder. There doesn't seem to be a field for that so I'm not sure what should be used here

Yes, this is correct. We don't have medical information notes on a per-application basis. It is best to just leave the application.notes here, as it is most likely that the notes attached to an application are related to the medical information

…/uwblueprint/richmond-centre-for-disability into jb/view-permit-holder-api-hookup

Co-authored-by: jennifer tsai <jennifertsai@users.noreply.github.com>

…/uwblueprint/richmond-centre-for-disability into jb/view-permit-holder-api-hookup

OustanDing

Great work guys! And thanks a lot @chrischan325 @angeladietz and @jennifertsai for picking up this ticket. I left some items to resolve. Some of the request changes will break the other files (eg. the moving the types to a tools file rather than leaving it in the page file) so be careful of that. Thanks again y'all :))

components/permit-holders/AppHistoryCard.tsx

pages/admin/permit-holder/[permitHolderId].tsx

prisma/schema.prisma

OustanDing

A lot better! A couple of small things and we should be good to go :)

components/permit-holders/DoctorInformationCard.tsx

components/permit-holders/GuardianInformationCard.tsx

components/permit-holders/PermitHolderHeader.tsx

pages/admin/permit-holder/[permitHolderId].tsx

components/permit-holders/DoctorInformationCard.tsx

components/permit-holders/GuardianInformationCard.tsx

components/permit-holders/PermitHolderHeader.tsx

components/requests/modals/EditDoctorInformationModal.tsx

tools/pages/admin/permit-holders/types.ts

…te for EditDoctorInformationModal, other small changes

OustanDing

LGTM!

j-bunk added 4 commits August 17, 2021 16:36

Partial hookup of edit modals

6caeb66

Generated graphql types + comment fix

eabaf87

Added default values to db + minor fixes to edit modal hookups

3b04f40

Fixed Edit user information modal api hookup

99381dd

j-bunk commented Aug 18, 2021

View reviewed changes

components/permit-holders/modals/EditUserInformationModal.tsx Show resolved Hide resolved

j-bunk commented Aug 18, 2021

View reviewed changes

Fixes to medical history card + table data handling

43c1c81

j-bunk commented Aug 18, 2021

View reviewed changes

angeladietz mentioned this pull request Aug 18, 2021

[Feature] Request Table API Hookup #45

Merged

3 tasks

OustanDing added the wip Work in progress label Aug 18, 2021

christianlippa and others added 7 commits August 23, 2021 23:00

init commit

d8fd6b4

Partial hookup of edit modals

c9d9006

Generated graphql types + comment fix

62e26ba

Added default values to db + minor fixes to edit modal hookups

701fcd3

Fixed Edit user information modal api hookup

d1667fe

Fixes to medical history card + table data handling

443adc8

init commit

e8a2161

angeladietz force-pushed the jb/view-permit-holder-api-hookup branch from d8fd6b4 to e8a2161 Compare August 24, 2021 12:38

chrischan325 and others added 12 commits August 24, 2021 13:54

Merge branch 'jb/view-permit-holder-api-hookup' of https://github.com…

05a8296

…/uwblueprint/richmond-centre-for-disability into jb/view-permit-holder-api-hookup

Fetch data through graphql query for medical history card

53d6337

Fix errors with populating medical history card

e695baf

Get permit holder id from url

dc3aad6

Merge branch 'jb/view-permit-holder-api-hookup' of https://github.com…

f9dc734

…/uwblueprint/richmond-centre-for-disability into jb/view-permit-holder-api-hookup

passed permitHolderId to PreviousDoctorsInformationModal

fc01e79

Fix bugs with Medical History Modal and Prev Doctors modal

657cc4f

Api hookup for attached files card

97cc58c

Co-authored-by: Angela Dietz <angeladietz@users.noreply.github.com>

e6f342a

Co-authored-by: jennifer tsai <jennifertsai@users.noreply.github.com>

Merge branch 'jb/view-permit-holder-api-hookup' of https://github.com…

a691d20

…/uwblueprint/richmond-centre-for-disability into jb/view-permit-holder-api-hookup

add notes to GET_APPLICANT_APPLICATIONS_QUERY

587865f

passing data to doctor and guardian cards

49e9f0e

angeladietz added 6 commits August 28, 2021 10:37

Fix build error

7996434

Fix schema.prisma

7a2dc8c

Fix get permit holder response type

d73204a

Set text to empty string if field is undefined

ff03ac7

Cleanup comments

18c3f51

Remove queries from permit holder cards

c1ff760

angeladietz requested a review from a team August 28, 2021 20:24

angeladietz added needs dev review Needs dev review and removed wip Work in progress labels Aug 28, 2021

OustanDing requested changes Aug 29, 2021

View reviewed changes

OustanDing added wip Work in progress and removed needs dev review Needs dev review labels Aug 29, 2021

chrischan325 and others added 3 commits August 29, 2021 22:57

addressing review comments

81fd980

Address pr feedback

0862e17

Resolve pr comments

415afb3

angeladietz requested a review from OustanDing August 30, 2021 15:18

OustanDing added needs dev review Needs dev review and removed wip Work in progress labels Aug 30, 2021

OustanDing requested changes Aug 30, 2021

View reviewed changes

chrischan325 added 2 commits August 30, 2021 16:19

resolving pr fixes

1dd4d2c

minor fixes

98c3dbf

OustanDing requested changes Aug 30, 2021

View reviewed changes

chrischan325 and others added 4 commits August 30, 2021 17:37

fixing imports and other minor fixes

3157403

Add row click functionality

55e66fa

Fix request physician updating failing, removed component loading sta…

dac73fe

…te for EditDoctorInformationModal, other small changes

Remove Netlify file

c23b640

OustanDing approved these changes Aug 31, 2021

View reviewed changes

chrischan325 merged commit 471b3d4 into staging Aug 31, 2021

chrischan325 deleted the jb/view-permit-holder-api-hookup branch August 31, 2021 20:34

OustanDing mentioned this pull request Sep 1, 2021

[Fix] Fix View Permit Holder API Hookup integration bugs #56

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature] View Permit Holder API hookup #50

[Feature] View Permit Holder API hookup #50

j-bunk commented Aug 18, 2021 •

edited by OustanDing

Loading

j-bunk Aug 18, 2021 •

edited

Loading

j-bunk Aug 18, 2021

OustanDing Aug 29, 2021

OustanDing left a comment

OustanDing left a comment

OustanDing left a comment

[Feature] View Permit Holder API hookup #50

[Feature] View Permit Holder API hookup #50

Conversation

j-bunk commented Aug 18, 2021 • edited by OustanDing Loading

Notion ticket link

Implementation description

Notes

Checklist

j-bunk Aug 18, 2021 • edited Loading

Choose a reason for hiding this comment

j-bunk Aug 18, 2021

Choose a reason for hiding this comment

OustanDing Aug 29, 2021

Choose a reason for hiding this comment

OustanDing left a comment

Choose a reason for hiding this comment

OustanDing left a comment

Choose a reason for hiding this comment

OustanDing left a comment

Choose a reason for hiding this comment

j-bunk commented Aug 18, 2021 •

edited by OustanDing

Loading

j-bunk Aug 18, 2021 •

edited

Loading