-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] View Request Page API Hookup #51
Conversation
35717a6
to
6c9e075
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really really good job! Thanks so much for all your hard work. Sorry there are so many comments, but they will really benefit the maintainability of the project <3
components/internal/modals/EditPermitHolderInformationModal.tsx
Outdated
Show resolved
Hide resolved
@jeffreyzhang2001 Did some general cleanup to resolve the TS errors we were running into. I changed the types generation config to disallow optionals (do not allow Also removed replacement logic from the |
cc @carelynntsai Removed replacement applications from this page to reduce complexity. Also removed the country field from the editing modals since we only allow Canada in the applicant-facing form. |
1b3018d
to
42da781
Compare
Notion ticket link
Ticket Name
Implementation description
Notes
input
types. This is a breaking change but will provide cleaner type checking and validation. Change made by @OustanDingChecklist
[Feature]
,[Improvement]
or[Fix]
,