Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Fix seeded users not having RCD user ID #62

Merged
merged 1 commit into from
Sep 16, 2021
Merged

[Fix] Fix seeded users not having RCD user ID #62

merged 1 commit into from
Sep 16, 2021

Conversation

OustanDing
Copy link
Member

@OustanDing OustanDing commented Sep 16, 2021 •
edited
Loading

Notion ticket link

Ticket

Implementation description

  • Please see Notion ticket for screenshot of issue. When seeding data, for the create parameter, some of the unique keys were omitted. This caused the seeded data to be missing the unique keys. RCD user ID was one of the missing keys. Also preemptively fixed other potential instances of missing columns.

Notes

  • Need to reseed staging database

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

@OustanDing OustanDing added the needs dev review Needs dev review label Sep 16, 2021
@OustanDing OustanDing merged commit c41612a into staging Sep 16, 2021
@OustanDing OustanDing deleted the od/bugfix/seeded-users-missing-rcd-user-id branch September 16, 2021 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs dev review Needs dev review
Projects
None yet
Milestone
No milestone
1 participant
@OustanDing