Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Get Employee Endpoint #69

Merged
merged 5 commits into from
Sep 25, 2021
Merged

[Feature] Get Employee Endpoint #69

merged 5 commits into from
Sep 25, 2021

Conversation

aaggarwal10
Copy link
Member

@aaggarwal10 aaggarwal10 commented Sep 25, 2021 •
edited
Loading

Notion ticket link

Get Employee Endpoint

Implementation description

Normal Query:
GetEmployee In GQPlayground
Null Case:
GetEmployee with Invalid ID

Checklist

  • My PR name is descriptive, is in imperative tense and starts with one of the following: [Feature],[Improvement] or [Fix],
  • I have run the appropriate linter(s)
  • I have requested a review from the RCD team on GitHub, or specific people who are associated with this ticket

OustanDing
OustanDing requested changes Sep 25, 2021
View reviewed changes
Copy link
Member

@OustanDing OustanDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolvers look good! WE just need to add the respective types to the GraphQL schema. Let's sync up on this

lib/employees/resolvers.ts Outdated Show resolved Hide resolved
lib/employees/resolvers.ts Outdated Show resolved Hide resolved
@aaggarwal10 aaggarwal10 requested a review from a team September 25, 2021 19:10
aaggarwal10 and others added 4 commits September 25, 2021 15:10
@aaggarwal10 @OustanDing
Update lib/employees/resolvers.ts
ca055b5 
Co-authored-by: Oustan Ding <oustan10@gmail.com>
@aaggarwal10 @OustanDing
Update lib/employees/resolvers.ts
dfda7da 
Co-authored-by: Oustan Ding <oustan10@gmail.com>
@aaggarwal10
Adding to schema
cab1888
@aaggarwal10
Fixing renaming args error.
2ff258b
OustanDing
OustanDing approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@OustanDing OustanDing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaggarwal10 aaggarwal10 merged commit 91411d6 into staging Sep 25, 2021
@aaggarwal10 aaggarwal10 deleted the feature/aa-adding-employee-endpoint branch September 25, 2021 19:18
@OustanDing
Copy link
Member

Just for clarification: some of the schemas for this endpoint were already built so they weren't included in this PR.

@OustanDing OustanDing added the ready to merge ✅ Ready to merge (all reviews received) label Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OustanDing OustanDing OustanDing approved these changes

Assignees
No one assigned
Labels
ready to merge ✅ Ready to merge (all reviews received)
Projects
None yet
Milestone
No milestone
2 participants
@aaggarwal10 @OustanDing