Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TN-2417 provide ugly workaround to failed query #3579

Merged
merged 1 commit into from Dec 10, 2019
Merged

Conversation

pbugni
Copy link
Collaborator

@pbugni pbugni commented Dec 10, 2019

Hopefully a temporary workaround, run a second query for the entire json document if the query for the json path field fails.

@pep8speaks
Copy link

Hello @pbugni! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 375:40: E251 unexpected spaces around keyword / parameter equals

@pbugni
Copy link
Collaborator Author

pbugni commented Dec 10, 2019

@ivan-c should we include a rollback of yesterdays SQLAlchemy downgrade attempt, as that didn't prove to be the problem?

Copy link
Member

@ivan-c ivan-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for branching from master!

Is there anything else (metadata, system state) we would want to log? Nothing comes to mind, but I'm not sure we'll be able to reproduce with QNR.id only

@ivan-c
Copy link
Member

ivan-c commented Dec 10, 2019

@ivan-c should we include a rollback of yesterdays SQLAlchemy downgrade attempt, as that didn't prove to be the problem?

I'd prefer to minimize change to master until we can figure this out. I'll merge what we have in master into develop and restore Wayne's changes there; they'll become part of the next release.

@pbugni
Copy link
Collaborator Author

pbugni commented Dec 10, 2019

@ivan-c should we include a rollback of yesterdays SQLAlchemy downgrade attempt, as that didn't prove to be the problem?

I'd prefer to minimize change to master until we can figure this out. I'll merge what we have in master into develop and restore Wayne's changes there; they'll become part of the next release.

Sure, sounds wise.

@pbugni
Copy link
Collaborator Author

pbugni commented Dec 10, 2019

Looks good, thanks for branching from master!

Is there anything else (metadata, system state) we would want to log? Nothing comes to mind, but I'm not sure we'll be able to reproduce with QNR.id only

I really don't know what else to log. We can't reproduce at all, but at least we'll have a pointer to the db row that behaved poorly.

@ivan-c ivan-c merged commit 08a7642 into master Dec 10, 2019
@ivan-c ivan-c deleted the hotfix/TN-2417 branch December 10, 2019 22:42
ivan-c added a commit that referenced this pull request Dec 11, 2019
…figure out the source of the problem. (#3579)"

This reverts commit 08a7642.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants