Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirm staff have valid email before attempt to send #4366

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

pbugni
Copy link
Collaborator

@pbugni pbugni commented Mar 6, 2024

found additional cases where test system may be attempting to send EMPRO alert emails to user's w/o a valid email address (staff).

added detailed logging where failure is occurring, as well.

@pep8speaks
Copy link

Hello @pbugni! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 117:80: E501 line too long (80 > 79 characters)

@pbugni pbugni requested a review from ivan-c March 6, 2024 20:51
Copy link
Member

@ivan-c ivan-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thank you!!

@pbugni pbugni merged commit 8c597ef into develop Mar 6, 2024
2 checks passed
@pbugni pbugni deleted the feature/catch-empro-missing-email-errors branch March 6, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants