stop emailing withdrawn

[pbugni]

Discovered withdrawn users continue to be sent reminder emails.

• This PR patches a number of incorrect usages of user.email_ready() (as it returns a tuple, a simple if user.email_ready() check is misleading.
• masks the email address of all withdrawn users, to make certain they aren't sent any additional messages (via a migration)
• blocks another path to hand trigger sending reminders. I doubt this was being used, but no reason to leave door open

[pep8speaks]

Hello @pbugni! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file portal/migrations/versions/5caf794c70a7_.py:

Line 39:80: E501 line too long (97 > 79 characters)
Line 49:5: E265 block comment should start with '# '
Line 58:80: E501 line too long (83 > 79 characters)
Line 62:1: E302 expected 2 blank lines, found 1
Line 66:80: E501 line too long (86 > 79 characters)
Line 68:80: E501 line too long (92 > 79 characters)
Line 85:80: E501 line too long (83 > 79 characters)
Line 87:80: E501 line too long (81 > 79 characters)
Line 94:80: E501 line too long (84 > 79 characters)
Line 104:5: E306 expected 1 blank line before a nested definition, found 0
Line 139:80: E501 line too long (89 > 79 characters)
Line 149:1: E303 too many blank lines (3)

• In the file portal/models/user.py:

Line 1320:5: E303 too many blank lines (2)
Line 1324:80: E501 line too long (82 > 79 characters)

• In the file tests/conftest.py:

Line 413:80: E501 line too long (85 > 79 characters)

Comment last updated at 2024-03-27 03:23:01 UTC

[ivan-c]

Looks good! Appreciate the high-level functional calls in the migration to helpers. Ran on stage with the latest prod data and looked good