Skip to content
This repository has been archived by the owner on May 19, 2022. It is now read-only.

Convert relevant asserts to exceptions #18

Closed
jtikalsky opened this issue Nov 15, 2018 · 1 comment
Closed

Convert relevant asserts to exceptions #18

jtikalsky opened this issue Nov 15, 2018 · 1 comment
Labels
enhancement

Comments

@jtikalsky
Copy link
Contributor

Now that #16 is complete, we are able to use exceptions in our code. Various things can now be upgraded to take advantage of this. The most obvious case is to review any configASSERTs in our code to determine if they would be better handled as catchable exceptions.
jtikalsky added a commit that referenced this issue Nov 15, 2018
@jtikalsky
Convert a huge number of configASSERT()s to if (!x) throw. #18
6853100
jtikalsky added a commit that referenced this issue Nov 15, 2018
@jtikalsky
Handle SDR validation via exceptions. #18
f3a5c26
@jtikalsky jtikalsky mentioned this issue Nov 17, 2018
Closed
@jtikalsky
Copy link
Contributor Author

I believe this is basically done.

jtikalsky added a commit that referenced this issue Feb 8, 2019
@jtikalsky
Convert a huge number of configASSERT()s to if (!x) throw. #18
0015c36
jtikalsky added a commit that referenced this issue Feb 8, 2019
@jtikalsky
Handle SDR validation via exceptions. #18
1a13033
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jtikalsky