docs: add types for setPlot and plot attributes #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Should we merge into #355 first? |
jheer
added a commit
that referenced
this pull request
Apr 6, 2024
* chore: Update TypeScript, add some jsdoc typings, address TS errors. * feat: Add initial TS types for JSON specs. * test: Add TypeScript spec tests. * feat: Incremental progress on JSON specification types. * docs: add types for setPlot and plot attributes (#353) * chore(deps): bump actions/configure-pages from 4 to 5 (#352) * docs: add types for setPlot and plot attributes --------- Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Use jsconfig and fix types * Enable checks for spec js * Fix type errors with ASTNode * Disable js tests in spec package * fix: Remove invalid plot attribute. * feat: Publish types from mosaic-spec. * feat: Add spec interactor typings. * feat: Document spec transform types. * feat: Document more spec typings. * feat: Types and documentation for plot attributes. * feat: Initial progress towards spec mark types. * feat: Add Area and Line mark types. * feat: Add more mark typings. * feat: Add vector and hexgrid mark typings. * feat: Add geo mark typings. * feat: Add delaunay mark types. * feat: Add arrow and link mark types. * chore: Add missing outer mark doc comments. * feat: Add spec types for image, raster, regression. * feat: Finish spec typings. --------- Co-authored-by: Dominik Moritz <domoritz@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping it would help detect things like #345 but we would need even stronger types.