-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keyboard navigation with the slideshow component #13
Comments
To see commit for the bug fix, go to ca6594c |
Note: attached to uweb/uw-slideshow@e8d9187 of uw-slideshow plugin |
Hey folks, I grabbed the changes to the slideshow from the master branch and rebuilt our child theme to incorporate it. I sent our internal ticket back to our tester, and he added more feedback. It looks like the items we reported haven't quite been addressed, and a few more issues have popped up. Here's the updated Actual Result section of the ticket: Actual Result:
We also wanted to see whether the changes to the slideshow affected other pages than ours, so we went to the HTML Components entry on the brand site and noticed the slide show demo was broken. |
Hi, Looking at your review, I am not experiencing the same issues. It may be the environment I set up, but just to be sure, I wanted to know if you had downloaded both changes. The first being from the UW-2014 theme, and the second being the update to the uw-slideshow plugin that I linked above. Just wanted to check both files had been updated. Thanks, |
Hi, This is Matt Lambert on the ORIS web team. I work with Greg, who logged this original bug. We have done some thinking and comparing with keyboard accessibility patterns found on other pages, and we have come to the conclusion that TAB navigation should not be enabled within the slideshow component. The slideshow itself should have a tab-stop, and the slideshow element should be outlined or highlighted in a way that indicates it has focus. But while focus is on the slideshow, a keyboard navigating user should be able to navigate from slide to slide using the arrow keys. Hitting TAB when focus is on the slideshow should cause focus to move to the next element on the page. As a result of this, we would like to consider the following areas:
Thanks, |
Hi Matt, Thank you for looking more into what other sites are doing. Go ahead and log the issues as new bugs, and we will add them to the to-do list. Thanks, |
Here's another set of issues that were reported by the testers in ORIS. I'm copying and pasting the bug story we have in our tracking system. You can substitute the URL in repro step no. 1 with http://www.washington.edu/brand/html-web-components/ and the effect should be the same.
Description:
The slider/slideshow carousel on on Research home page has accessibility issues. The carousel arrows do not highlight when the tab focus is on them, it has a double tab stop for each slide and stories do not advance appropriately.
Impact:
Users that use tab or voice functionality are not able to access the carousel's controls and view the slide stories.
Repro Steps:
Expected Result
Actual Result:
The text was updated successfully, but these errors were encountered: