setup.py: add requests to setup_requires #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See #16 and http://stackoverflow.com/questions/27497470/setuptools-finds-wrong-package-during-install Multiple hours of 100's of Google searches eventually took me to this numpy thread: numpy/numpy#2434 (comment) for which they had to add numpy to `setup_requires` AND `install_requires` to fix a similar issue. Doing this with requests seems to have worked. However, I am somewhat skeptical as posters on SO indicated they did not see our problem in the first place. I may just be getting lucky. I tried on my Mac as well as on Ubuntu (dbserver02), and am able to install from a clean virtualenv on both systems. Fix #16 for now.
dhalperi
force-pushed
the
fix-16-maybe
branch
from
34db11a
to
47b720e
Compare
dhalperi
added a commit
that referenced
this pull request
Dec 20, 2014
setup.py: add requests to setup_requires
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #16 and
http://stackoverflow.com/questions/27497470/setuptools-finds-wrong-package-during-install
Multiple hours of 100's of Google searches eventually took me to this
numpy thread:
numpy/numpy#2434 (comment)
for which they had to add numpy to
setup_requiresANDinstall_requiresto fix a similar issue. Doingthis with requests seems to have worked. However, I am somewhat
skeptical as posters on SO indicated they did not see our problem in the
first place.
I tried on my Mac as well as on Ubuntu (dbserver02), and am able to
install from a clean virtualenv on both systems.
Fix #16 for now.