Slxu extend operation future and fix a race condition #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pre-notify listeners to OperationFuture. These listeners get executed after the operation is done and before waiting threads getting woke up. This is to solve existing race conditions. For example, in DatasetMetadataUpdater, the metada gets updated after a qurey is executed by getting executed in a QueryFuture listener. But if any thread is syncing on the same QueryFuture, the thread may see the query is finished but the metadata is still not updated. Meet this race condition in a run of systemtest.JsonQuerySubmitTest
…onFuture-and-fix-a-race-condition
…e-and-fix-a-race-condition
|
Nice catch! Interesting fix. |
dhalperi
added a commit
that referenced
this pull request
Feb 22, 2014
…nd-fix-a-race-condition Slxu extend operation future and fix a race condition
dhalperi
deleted the
slxu-extend-OperationFuture-and-fix-a-race-condition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.