Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.gradle: count system tests in code coverage #525

Merged
merged 4 commits into from
May 22, 2014

Conversation

dhalperi
Copy link
Member

  1. fix build.gradle to include systemtest execution reports in the test report. This bumps coverage from 27% to 50%, even when it only gets the server side of the report.

  2. fix Java to pass the user agent down to the started workers (SystemTestBase) so that worker code is included. Surprisingly, this seems to bump coverage only to about 55%.

@coveralls
Copy link

Coverage Status

Coverage increased (+23.97%) when pulling f5384e8 on jacoco-count-systemtests into 1ac65d4 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+24.07%) when pulling 3748673 on jacoco-count-systemtests into 1ac65d4 on master.

dhalperi added a commit that referenced this pull request May 22, 2014
build.gradle: count system tests in code coverage
@dhalperi dhalperi merged commit 9243297 into master May 22, 2014
@coveralls
Copy link

Coverage Status

Coverage increased (+29.57%) when pulling 46d567d on jacoco-count-systemtests into 1ac65d4 on master.

@domoritz domoritz deleted the jacoco-count-systemtests branch May 22, 2014 17:15
@domoritz
Copy link
Member

Thanks for writing sooo many tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants