fix_constant_emit_in_statefulapply #867
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a
StatefulApply
has a constant emitter (e.g. sin(-1)), it still constructs aGenericEvaluator
for it, which is not compiled (due to being a constant). Then the evaluator is null wheneval()
is called. Instead, aConstantEvaluator
should be constructed (same as inApply
), which compiles in its constructor. A counter example is:APPLY counter() { [0 AS c]; [c + 1]; c; }; R = scan(TwitterK); R_seq = select R.*, sin(-1) as t, counter() as c from R;