Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_constant_emit_in_statefulapply #867

Closed
wants to merge 2 commits into from

Conversation

jingjingwang
Copy link
Contributor

If a StatefulApply has a constant emitter (e.g. sin(-1)), it still constructs a GenericEvaluator for it, which is not compiled (due to being a constant). Then the evaluator is null when eval() is called. Instead, a ConstantEvaluator should be constructed (same as in Apply), which compiles in its constructor. A counter example is:

APPLY counter() { [0 AS c]; [c + 1]; c; }; R = scan(TwitterK); R_seq = select R.*, sin(-1) as t, counter() as c from R;

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 27.364% when pulling 838aac0 on fix_constant_emit_in_statefulapply into b61a318 on master.

@jingjingwang jingjingwang assigned parmitam and unassigned senderista Jan 17, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 27.365% when pulling 7ccc8e2 on fix_constant_emit_in_statefulapply into b61a318 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants