Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the encoding for CSVFragmentTupleSource #897

Merged
merged 2 commits into from
Jun 7, 2017
Merged

Fixed the encoding for CSVFragmentTupleSource #897

merged 2 commits into from
Jun 7, 2017

Conversation

jortiz16
Copy link
Contributor

@jortiz16 jortiz16 commented Jun 7, 2017

Fixed the encoding so we use the CSV parameters from the CsvTupleReader. Also, renamed CSVFileScanFragment to CSVFragmentTupleSource to match with TupleSource.

@jortiz16 jortiz16 requested a review from senderista June 7, 2017 20:48
@jortiz16 jortiz16 mentioned this pull request Jun 7, 2017
Merged
senderista
senderista approved these changes Jun 7, 2017
View reviewed changes
Copy link
Contributor

@senderista senderista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I guess your RACO changes to use parallel ingest for S3 CSV load() statements will also change the encoding name?

@jortiz16
Copy link
Contributor Author

jortiz16 commented Jun 7, 2017

Yeah, I recently opened a PR for RACO. It uses the new encoding name

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 26.991% when pulling 5fdcc02 on fixing-CSVFragmentTupleSource into 625b0e7 on master.

@jortiz16 jortiz16 merged commit 262de2f into master Jun 7, 2017
@jortiz16 jortiz16 deleted the fixing-CSVFragmentTupleSource branch June 7, 2017 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senderista senderista senderista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jortiz16 @coveralls @senderista