fixing parallel ingest single worker case #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senderista
approved these changes
Jun 8, 2017
| long startByteRange = currentPartitionSize * workerIndex; | ||
| long endByteRange; | ||
| if (workerIndex >= 0) { | ||
| boolean isLastWorker = workerIndex == workerIds.length - 1; |
There was a problem hiding this comment.
Parens around the condition would be more readable (I realize this was in the original).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an ingest bug for cases where parallel ingest only needed a single worker to read a file. With the old code, every worker would try to read the entire file (since
workerIndexvalue was kept at 0). In other words, every worker would believe they were the first worker.Now,
workerIndexstarts at -1 and is only assigned to read the file if it is found in the workerIds array. IfworkerIndexis kept at -1, we markflagAsIncompleteas True which then makes sure to not initialize the parser for the current worker.