Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add limit to the dataset download api #915

Merged
merged 1 commit into from
Sep 8, 2017
Merged

add limit to the dataset download api #915

merged 1 commit into from
Sep 8, 2017

Conversation

jingjingwang
Copy link
Contributor

Solves #730. Will add an integrated test once this feature is in Python.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 26.788% when pulling 849a2c1 on add_limit_to_dataset_api into 5732f48 on master.

senderista
senderista approved these changes Sep 8, 2017
View reviewed changes
Copy link
Contributor

@senderista senderista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@senderista senderista merged commit 8d826d6 into master Sep 8, 2017
@senderista senderista deleted the add_limit_to_dataset_api branch September 8, 2017 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@senderista senderista senderista approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jingjingwang @coveralls @senderista