Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Authentication with Gitlab #303

Merged
merged 5 commits into from Sep 7, 2020
Merged

✨ Authentication with Gitlab #303

merged 5 commits into from Sep 7, 2020

Conversation

wizzytod
Copy link
Contributor

Users can sign in/sign up with Gitlab OAuth2 provider.
Login with gitlab

madmath03
madmath03 suggested changes Aug 24, 2020
View reviewed changes
backend/src/app/http/auth/gitlab.clj Outdated Show resolved Hide resolved
backend/src/app/http/auth/gitlab.clj Outdated Show resolved Hide resolved
wizzytod and others added 2 commits August 24, 2020 13:16
@wizzytod @madmath03
✏️ Log message typo
5408d28 
Co-authored-by: Mathieu Brunot <mathieu.brunot@monogramm.io>
@wizzytod @madmath03
✏️ Log message typo)
a05fa07 
Co-authored-by: Mathieu Brunot <mathieu.brunot@monogramm.io>
@wizzytod wizzytod marked this pull request as ready for review August 24, 2020 11:17
madmath03
madmath03 approved these changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@madmath03 madmath03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @wizzytod , this looks awesome!

@niwinz niwinz self-requested a review September 7, 2020 07:49
niwinz
niwinz approved these changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@niwinz niwinz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@niwinz niwinz merged commit e926dc2 into penpot:develop Sep 7, 2020
@wizzytod wizzytod mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niwinz niwinz niwinz approved these changes

@madmath03 madmath03 madmath03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wizzytod @niwinz @madmath03