React16 #12
Merged
React16 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eternalsky
reviewed
Jun 14, 2018
src/Album.jsx
Outdated
| constructor(props) { | ||
| super(props); | ||
| this.state = { | ||
| open: false, | ||
| current: props.current, | ||
| left: 0, | ||
| top: 0, | ||
| lastIndex: 0, |
There was a problem hiding this comment.
这个 lastIndex 应该也是用 props.current 来生成，这样才可以避免，mount 时候走两遍逻辑。
src/Album.jsx
Outdated
| } | ||
| }; | ||
|
|
||
| export default polyfill(Album); |
There was a problem hiding this comment.
按照 https://github.com/reactjs/react-lifecycles-compat 标准用法，应该 polyfill(Album); 再 export default Album 更靠谱一些。
src/Carousel.jsx
Outdated
| this.state = { | ||
| left: 0, | ||
| top: 0, | ||
| lastIndex: 0, |
There was a problem hiding this comment.
这里同上，lastIndex 作为 current 的 mirror，应该在 constructor 中也用 current 来生成。
src/Viewer.jsx
Outdated
| scale: 1, | ||
| current: props.current, | ||
| lastOpenStatus: false, |
src/Carousel.jsx
Outdated
| @@ -180,3 +190,5 @@ export default class Carousel extends React.Component { | |||
| ); | |||
| } | |||
| } | |||
|
|
|||
| export default polyfill(Carousel); | |||
src/Viewer.jsx
Outdated
| @@ -265,3 +276,5 @@ Viewer.propTypes = { | |||
| }; | |||
|
|
|||
| Viewer.displayName = 'Viewer'; | |||
|
|
|||
| export default polyfill(Viewer); | |||
|
没啥问题了，可以和 文肇 商量下，看谁来发。 |
|
reopen pr for merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update react 16