Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade react to 15 #4

Merged
merged 3 commits into from
Oct 30, 2017
Merged

upgrade react to 15 #4

merged 3 commits into from
Oct 30, 2017

Conversation

buzhou
Copy link
Collaborator

@buzhou buzhou commented Oct 28, 2017

upgrade react to 15
ut added,
fix jslint issues

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 9e1cd0c on buzhou:master into ** on uxcore:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 081b2ab on buzhou:master into ** on uxcore:master**.

@buzhou
Copy link
Collaborator Author

buzhou commented Oct 30, 2017

change cjs to es6, change React.PropTypes to prop-types

demo/index.js Outdated
@@ -5,6 +5,8 @@
* Copyright 2014-2015, Uxcore Team, Alinw.
* All rights reserved.
*/
const React = require('react');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里还没有 es6 化~

@eternalsky
Copy link
Member

其他的 ok

tests/index.js Outdated
import spec from './Alert.spec';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里同上一个组件的 comment

@eternalsky
Copy link
Member

ok

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0258b37 on buzhou:master into ** on uxcore:master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 0258b37 on buzhou:master into ** on uxcore:master**.

@buzhou buzhou merged commit 9f05b6e into uxcore:master Oct 30, 2017
@buzhou buzhou changed the title 升级到react 15 upgrade react to 15 Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants