React16 #3
Merged
React16 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eternalsky
reviewed
Jun 27, 2018
src/ScrollNumber.jsx
Outdated
| // 等待数字位置复原完毕, | ||
| // 开始设置完整的数字 | ||
| if (this.props.count !== prevProps.count) { | ||
| this.setState({ |
There was a problem hiding this comment.
在 didUpdate 里不能 setState，这样会引起二次渲染，所有的 setState 相关的操作，都考虑放到getDerivedStateFromProps 中
| @@ -77,9 +82,9 @@ class ScrollNumber extends React.Component { | |||
| return 10 + num; | |||
| } | |||
| const currentDigit = getNumberArray(this.state.count)[i]; | |||
| const lastDigit = getNumberArray(this.lastCount)[i]; | |||
| const lastDigit = getNumberArray(this.state.lastCount)[i]; | |||
There was a problem hiding this comment.
我感觉 lastCount 的逻辑很奇怪，如果放到 getDerivedStateFromProps 里，因为 gDSFP 在每次渲染时都会调用，要看下跟以前在 cWRP 里的表现还是否一致。根据代码里的注释。
added 2 commits
June 28, 2018 10:02
eternalsky
reviewed
Jun 28, 2018
src/ScrollNumber.jsx
Outdated
| // 等待数字位置复原完毕, | ||
| // 开始设置完整的数字 | ||
| if (this.props.count !== prevProps.count) { | ||
| this.lastCount = prevProps.count; |
There was a problem hiding this comment.
这里逻辑不太对，以前是拿的 state.count ,那这里应该指向 prevState.count 吧
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.