-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React 15.x支持 #9
React 15.x支持 #9
Conversation
src/Carousel.jsx
Outdated
@@ -9,6 +9,11 @@ | |||
// matchMedia polyfill for | |||
// https://github.com/WickyNilliams/enquire.js/issues/82 | |||
|
|||
import classnames from 'classnames'; | |||
import * as React from 'react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里直接 import React 应该就可以了吧。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
都可以的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paseo 是都可以,但是感觉这样意义不大,为了统一,还是都改成 import React
好了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已改
src/index.js
Outdated
module.exports = require('./Carousel'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这一行没有 ES6 化。
改动内容:
yo uxcore:upgrade
命令,更新package.jsontnpm run lint
抛出的代码格式错误