-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First Version #2
Conversation
"object-assign": "^4.0.0" | ||
"object-assign": "^4.0.0", | ||
"rc-cascader": "^0.9.9", | ||
"underscore": "^1.8.3" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
underscore 太大,不能引入,请换用 es5/es6 方法实现。
}, | ||
"dependencies": { | ||
"classnames": "^2.1.2", | ||
"object-assign": "^4.0.0" | ||
"object-assign": "^4.0.0", | ||
"underscore": "^1.8.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
underscore 还没有去掉,请参考之前的comment,不引入大库
@eternalsky Done. |
document.body.removeChild(div); | ||
}); | ||
|
||
it('should display placeholder', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个 test 我这里过不了,另外 querySelector 没法在 IE8 下跑,这里可以 require 1.x 的 jquery,jquery 作为 devDenpendence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
测试已改,querySelector 已删。
Please review my code and merge.