React16 #24
Merged
React16 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eternalsky
reviewed
Jun 24, 2018
src/util.js
Outdated
| @@ -58,19 +58,23 @@ const getOptions = (options, value = [], level = 0) => { | |||
| if (level === 0 && options) { | |||
| return options; | |||
| } | |||
| console.log("getOptions", options, value) | |||
There was a problem hiding this comment.
console log 是否要删除，看这里好像不是一个 warning 相关的
src/CascadeSelect.jsx
Outdated
| @@ -180,10 +193,10 @@ class CascadeSelect extends SuperComponent { | |||
| recursive(); | |||
| } | |||
|
|
|||
| getSelectedOptions(props) { | |||
| static getSelectedOptions(props, state) { | |||
src/CascadeSelect.jsx
Outdated
| @@ -16,23 +16,24 @@ import CascadeSubmenu from './CascadeSubmenu'; | |||
| import SuperComponent from './SuperComponent'; | |||
| import Search from './Search'; | |||
|
|
|||
| import { find, getArrayLeafItemContains, deepCopy, getOptions } from './util'; | |||
| import { find, getArrayLeafItemContains, deepCopy, getOptions, stringify } from './util'; | |||
src/CascadeSelect.jsx
Outdated
| if ( | ||
| onSelect && judgeValue || judgeOptions | ||
| ) { | ||
| this.setValue(this.props); |
There was a problem hiding this comment.
追了一下，发现 setValue 最终会触发 setState，那么最好不要在 didUpdate 里调用，最好进一步拆解到 gDSFP 里
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: upgrade to support reac16