Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

增强部分功能 #6

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
"react"
],
"env": {
"browser": true
"browser": true,
"node": true,
"mocha": true
},
"rules": {
"import/no-extraneous-dependencies": "off",
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,5 @@ spm_modules
.happypack
dist
build
coverage
assets/**/*.css
35 changes: 29 additions & 6 deletions demo/CheckboxGroupDemo.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ class Demo extends React.Component {
value: ['air'],
disabled: false,
};

this.handleChange = this.handleChange.bind(this);
this.handleChange2 = this.handleChange2.bind(this);
this.handleChangeLayout = this.handleChangeLayout.bind(this);
}

handleChange(value) {
Expand All @@ -35,20 +39,38 @@ class Demo extends React.Component {
});
}

handleChangeLayout() {
this.setState({
verticalAlign: !this.state.verticalAlign,
});
}

render() {
const {
disabled,
value,
verticalAlign,
} = this.state;
return (
<div>
<div style={{
padding: '50px',
}}
>
<CheckboxGroup
disabled={this.state.disabled}
onChange={this.handleChange.bind(this)}
value={this.state.value}
disabled={disabled}
onChange={this.handleChange}
value={value}
verticalAlign={verticalAlign}
>
<Item
text="天空天空天空"
value="air"
addon={
<Popover overlay={<div>提示</div>}>
<i className="kuma-icon kuma-icon-caution" style={{ color: 'blue', fontSize: '12px', marginLeft: '3px' }} />
<i
className="kuma-icon kuma-icon-caution"
style={{ color: 'blue', fontSize: '12px', marginLeft: '3px' }}
/>
</Popover>
}
/>
Expand All @@ -58,7 +80,8 @@ class Demo extends React.Component {
<Item text="火车飞机飞机" value="train" />

</CheckboxGroup>
<Button onClick={this.handleChange2.bind(this)}>改变 state</Button>
<Button onClick={this.handleChange2}>改变 state</Button> &nbsp;
<Button onClick={this.handleChangeLayout}>改变布局</Button>
</div>
);
}
Expand Down
25 changes: 17 additions & 8 deletions src/CheckboxGroup.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import React from 'react';
import PropTypes from 'prop-types';
import Item from './CheckboxItem';


const shallowArrayCopy = (a) => {
const value = a instanceof Array ? [...a] : a;
return value;
Expand All @@ -37,17 +36,25 @@ class CheckboxGroup extends React.Component {

processChild() {
const me = this;
const {
value,
disabled,
verticalAlign,
} = me.props;
const length = React.Children.count(me.props.children);
if (!length) return false;
const elements = React.Children.map(me.props.children, (child, index) => {
if (!!child.type && child.type.displayName === 'CheckboxItem') {
const value = me.props.value;
return React.cloneElement(child, {
jsxdisabled: me.props.disabled,
onChange: me.handleChange.bind(me),
key: index,
checked: ((Array.isArray(value) ? value : [value]).indexOf(child.props.value) !== -1),
});
return (
<span className={`kuma-checkbox-group-${verticalAlign ? 'row' : 'cell'}`}>
{React.cloneElement(child, {
jsxdisabled: disabled,
onChange: me.handleChange.bind(me),
key: index,
checked: ((Array.isArray(value) ? value : [value]).indexOf(child.props.value) !== -1),
})}
</span>
);
}
return null;
});
Expand Down Expand Up @@ -81,6 +88,7 @@ CheckboxGroup.defaultProps = {
onChange: () => { },
disabled: false,
className: 'kuma-checkbox-group',
verticalAlign: false,
};


Expand All @@ -90,6 +98,7 @@ CheckboxGroup.propTypes = {
onChange: PropTypes.func,
disabled: PropTypes.bool,
className: PropTypes.string,
verticalAlign: PropTypes.bool,
};

CheckboxGroup.displayName = 'CheckboxGroup';
Expand Down
4 changes: 4 additions & 0 deletions src/CheckboxGroup.less
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,7 @@
color: @normal-alpha-5;
}
}

.@{__checkbox-prefix-cls}-row {
display: block;
}
33 changes: 27 additions & 6 deletions src/CheckboxItem.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,26 @@ class CheckboxItem extends React.Component {
const me = this;
me.props.onChange(e.currentTarget.checked, me.props.value);
}

render() {
const me = this;
const { prefixCls, className } = me.props;
const {
prefixCls,
className,
checked,
addon,
showAddonWhenChecked,
} = me.props;
let disabled = false;
if (me.props.disabled !== undefined) {
disabled = me.props.disabled;
} else {
disabled = me.props.jsxdisabled;
}
let showAddon = true;
if (!addon || (showAddonWhenChecked && !checked)) {
showAddon = false;
}
return (
<label
className={classnames(`${prefixCls}`, {
Expand All @@ -27,14 +38,19 @@ class CheckboxItem extends React.Component {
<input
type="checkbox"
disabled={disabled}
checked={me.props.checked}
checked={checked}
className="kuma-checkbox"
onChange={me.handleChange.bind(me)}
/>
<s />
<span className={`${prefixCls}-content`} >
<span dangerouslySetInnerHTML={{ __html: me.props.text }} />
{me.props.addon}
<span className={`${prefixCls}-content`}>
<span
className="kuma-checkbox-group-item-text"
dangerouslySetInnerHTML={{ __html: me.props.text }}
/>
{showAddon ? (
<span className="kuma-checkbox-group-item-addon">{addon}</span>
) : null}
</span>
</label>
);
Expand All @@ -44,7 +60,10 @@ class CheckboxItem extends React.Component {
CheckboxItem.defaultProps = {
value: '',
prefixCls: 'kuma-checkbox-group-item',
onChange() { },
onChange() {
},
addon: null,
showAddonWhenChecked: false,
};

CheckboxItem.propTypes = {
Expand All @@ -53,6 +72,8 @@ CheckboxItem.propTypes = {
prefixCls: PropTypes.string,
className: PropTypes.string,
onChange: PropTypes.func,
addon: PropTypes.node,
showAddonWhenChecked: PropTypes.bool,
};

CheckboxItem.displayName = 'CheckboxItem';
Expand Down
4 changes: 3 additions & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,6 @@
* All rights reserved.
*/

export default from './CheckboxGroup';
import CheckboxGroup from './CheckboxGroup';

export default CheckboxGroup;
105 changes: 0 additions & 105 deletions tests/CheckboxGroup.spec.js

This file was deleted.