upgrade to react 16 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eternalsky
reviewed
Jun 21, 2018
src/Popover.jsx
Outdated
| visible: nextProps.visible, | ||
| }); | ||
| static getDerivedStateFromProps(props, states) { | ||
| if (('visible' in props) && props.visible !== states.visible) { |
There was a problem hiding this comment.
这个修改不太正确，原意是 props 不同时，通过 props 生成新的 state，而新的逻辑里，变成了比较新的 props 和老的 state 是否相同，不相同则更新成新的 props，意义不同。应该对 props.visible 在 state 中做拷贝，比较 props 和拷贝版本是否相同。
|
没啥问题，可以合并发布了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.