MediaDisplayObject's notify emits "end"

uxebu · Sep 27, 2013 · 22ce3e0 · 22ce3e0
1 parent 03b86f8
commit 22ce3e0
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/runner/media_display_object.js b/src/runner/media_display_object.js
@@ -110,7 +110,11 @@ define([
       case 'error':
         // We trigger the event asynchronously so as to ensure that any events
         // bound after instantiation are still triggered:
-        this.emitAsync('error', Error(data.error));
+        this.emitAsync('error', new Error(data.error));
+        break;
+      case 'end':
+        this.emit('end', this);
+        break;
     }
 
     return this;

diff --git a/test/media_display_object-spec.js b/test/media_display_object-spec.js
@@ -68,6 +68,20 @@ require([
         });
       });
 
+      describe('notify', function() {
+        it('returns the current instance', function() {
+          var mediaDisplayObject = new MediaDisplayObject();
+          expect(mediaDisplayObject.notify()).toBe(mediaDisplayObject);
+        });
+        it('emits "end" on type=end', function() {
+          var mediaDisplayObject = new MediaDisplayObject();
+          var endSpy = jasmine.createSpy('end');
+          mediaDisplayObject.on('end', endSpy);
+          mediaDisplayObject.notify('end');
+          expect(endSpy).toHaveBeenCalledWith(mediaDisplayObject);
+        });
+      });
+
     });
 
   });