Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Indicate position of Memory View window on address space bar #1232

Closed
throwaway96 opened this issue Dec 26, 2022 · 5 comments

Comments

@throwaway96
Copy link
Contributor

You could apply a translucent overlay or invert the colors of the area corresponding to what's visible in the Memory View. It also may be desirable to add an indication of the current selection.

@uxmal
Copy link
Owner

uxmal commented Jan 20, 2023

I've completed implementing showing the selected address range in the address bar. Can you attach a screen shot, using mspaint or the like to indicate what you wish to happen when you ask:

apply a translucent overlay or invert the colors of the area corresponding to what's visible in the Memory View

@uxmal
Copy link
Owner

uxmal commented Jan 20, 2023

Here is a manipulated screenshot; note the new "selected address" in the status bar. Do you want the pink area to be updated as the selection changes (color would of course be different)? Or do you want other user interface elements to change color?
slask

@throwaway96
Copy link
Contributor Author

What I meant was something like this:
address-highlight
The highlighted part of the bar would correspond with what's visible on the screen (003AFFB0-003B0110 in this example). I'm not sure whether the selection should show up on the address bar. It'll probably be relatively small in most cases, although I guess it could just appear as a line. Maybe what's visible on the screen should be highlighted (or outlined) in one color, and the selection would be another (darker?) color.

I do also want what you've shown in your image. This is how HxD does it:
image
image
The darker color is what's actually selected.

@uxmal
Copy link
Owner

uxmal commented Jan 31, 2023

Commit 97f596b now tracks the selection in the imagemap view:image

Last remaining part is selecting the char-bytes part of the selection.

uxmal added a commit that referenced this issue Feb 1, 2023
The interface now renders individual memory bytes-as-text. This allows finer control of rendering, which will help when implementing #1232.

Fixed serious selection bugs in LowLevelViewInteractor and MemoryControl.
@uxmal
Copy link
Owner

uxmal commented Feb 1, 2023

Text side of the memory control is now fully selectable, just like the numeric side. The "other side" will be highlighted so it's easier to see the selection:
image
The features requested have been implemented. If you can think of improvements, please feel free to open a new issue and describe them.

@uxmal uxmal closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants