-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move update
functionality to setDate
and remove update
#575
Comments
I see no use case where you want to setDate without getting the UI updated. |
Hi Would also be nice if setDate could support the jqueryUi signature, namely
I was most interested in the string in the current form, and null parameter |
I think you should not merge those functions, because otherwise it would be hard to realize some kind of multiple-datepicker. |
How come that datepicker popup doesn't have a date selected? |
Shouldn't update trigger changeDate? |
@fletchowns +1. I think changeDate should be triggered. One should be able to count on changeDate event to do other stuff. |
I agree that setDate should fire an update as well. After a question on StackOverflow, I found out that even datepicker('update', new Date()) does not update the UI: http://jsfiddle.net/svierkant/9Xek7/7/ |
@eternicode I'm just tracing this issue through the github regarding setDate / update not affecting the UI. I accept that the documentation says "setDate" will affect the internal date, but "update" now seems to do nothing at all? This seems in be at odds with your previous message: "The documentation states that setDate "Sets the internal date." It says nothing about updating the UI etc; update is the right choice for a proper "update" of everything. It was broken somewhere along the way, though, and 95f06bc (will be in 1.2.0) fixes it to properly update the UI as expected. #575 in 2.0.0 will move the update functionality to setDate." |
Version 1.4.0
|
As evidenced by a rash of related bugs (#399, #466, #544, #554, #556), people expect
setDate
to behave asupdate
does (and, not coincidentally, how jQuery UI datepicker'ssetDate
does) -- despite the documentation clearly stating thatsetDate
"sets the internal date", nothing more.The text was updated successfully, but these errors were encountered: