New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework grunt tasks #1185
Rework grunt tasks #1185
Conversation
' * Copyright 2012 Stefan Petre\n' + | ||
' * Improvements by Andrew Rowls\n' + | ||
' * Licensed under the Apache License v2.0 (http://www.apache.org/licenses/LICENSE-2.0>)\n' + | ||
' */\n', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be cleaner using Array#join:
banner: [
'/*!',
' * Datepicker for Bootstrap v<%= pkg.version %> (<%= pkg.homepage %>)',
' *',
' * Copyright 2012 Stefan Petre',
' * Improvements by Andrew Rowls',
' * Licensed under the Apache License v2.0 (<http://www.apache.org/licenses/LICENSE-2.0>)',
' */'
].join('\n'),
Also, either you're missing a "<" in the license link, or you have an extra ">" at the end of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed and removed the < & > around the url!
ed8d05f
to
9071f92
Compare
a222222
to
402e58b
Compare
0c086dd
to
6b109ca
Compare
63d7ae5
to
59ba41e
Compare
0984a3e
to
7287b22
Compare
ca0f2ee
to
98beb52
Compare
@eternicode @abeverley @hebbet This PR is ready now, can you guys do a quick review. The grunt tasks have changed a bit so that we always have a dist folder with the files of the latest release, the version is now included in the files banner and the js/css rules are now correctly applied. Currently I didn't change any jscs rules and disabled the css lint task as I'm going to create a new pr to discuss new/stricter rules and clean up the css lint issues. The plan is to have this PR merged this week, after that I fix PR #1205 and close all related issues. |
@acrobat lgtm, but i would add version info, licence in a short form also in css and min.css |
Hmm that's something that supposed to happen, I will fix that tomorrow! |
@hebbet I've pushed a new version of the grunt tasks the issue with the banner in css files is resolved. |
👍 for merge. |
merged |
This pull-request will rework the grunt tasks and prepare the repository for the new release process.
Todo's:
Fixes: #1166
After this PR is merged I will create a new pull request to introduce some new/stricter js rules and include the css lint rules in the grunt test task