Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework grunt tasks #1185

Merged
merged 2 commits into from Feb 10, 2015
Merged

Rework grunt tasks #1185

merged 2 commits into from Feb 10, 2015

Conversation

acrobat
Copy link
Member

@acrobat acrobat commented Dec 14, 2014

This pull-request will rework the grunt tasks and prepare the repository for the new release process.

Todo's:

  • Update dependencies to higher version
  • Rework current grunt tasks
  • Create tasks for new release process to dist folder and dist.zip
  • Clean javascript/css against the jshint, jscs, css lint rules
  • Add version to banner of dist files

Fixes: #1166

After this PR is merged I will create a new pull request to introduce some new/stricter js rules and include the css lint rules in the grunt test task

' * Copyright 2012 Stefan Petre\n' +
' * Improvements by Andrew Rowls\n' +
' * Licensed under the Apache License v2.0 (http://www.apache.org/licenses/LICENSE-2.0>)\n' +
' */\n',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be cleaner using Array#join:

    banner: [
        '/*!',
        ' * Datepicker for Bootstrap v<%= pkg.version %> (<%= pkg.homepage %>)',
        ' *',
        ' * Copyright 2012 Stefan Petre',
        ' * Improvements by Andrew Rowls',
        ' * Licensed under the Apache License v2.0 (<http://www.apache.org/licenses/LICENSE-2.0>)',
        ' */'
    ].join('\n'),

Also, either you're missing a "<" in the license link, or you have an extra ">" at the end of it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and removed the < & > around the url!

@acrobat
Copy link
Member Author

acrobat commented Feb 8, 2015

@eternicode @abeverley @hebbet

This PR is ready now, can you guys do a quick review. The grunt tasks have changed a bit so that we always have a dist folder with the files of the latest release, the version is now included in the files banner and the js/css rules are now correctly applied.

Currently I didn't change any jscs rules and disabled the css lint task as I'm going to create a new pr to discuss new/stricter rules and clean up the css lint issues.

The plan is to have this PR merged this week, after that I fix PR #1205 and close all related issues.

@hebbet
Copy link
Contributor

hebbet commented Feb 8, 2015

@acrobat lgtm, but i would add version info, licence in a short form also in css and min.css

@acrobat
Copy link
Member Author

acrobat commented Feb 8, 2015

Hmm that's something that supposed to happen, I will fix that tomorrow!

@acrobat
Copy link
Member Author

acrobat commented Feb 9, 2015

@hebbet I've pushed a new version of the grunt tasks the issue with the banner in css files is resolved.

@acrobat acrobat changed the title [WIP] Rework grunt tasks Rework grunt tasks Feb 9, 2015
@vsn4ik
Copy link
Member

vsn4ik commented Feb 10, 2015

👍 for merge.

hebbet added a commit that referenced this pull request Feb 10, 2015
@hebbet hebbet merged commit 62f215a into uxsolutions:master Feb 10, 2015
@hebbet
Copy link
Contributor

hebbet commented Feb 10, 2015

merged

This was referenced Feb 10, 2015
@acrobat acrobat deleted the update-grunt-config branch September 26, 2016 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a dist folder
4 participants