New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add commonjs support #1451
Add commonjs support #1451
Conversation
👍 for merge. |
Thanks @zaynetro! |
Hi,
Is this the proper way to use it? |
@vshulev use |
@vsn4ik, thanks for the reply! This also doesn't seem to work (tried it and got an error). The issue seems to be that nothing is added to |
Could you provide an example when this breaks? I use bootstrap date picker in production and it does work with browserify. Perhaps there might be different between versions in how jquery/npm/browserify manage modules. |
I'm using the bootstrap datepicker inside an Angular directive (not sure whether this makes any difference). These are the top 3 lines in my directive file:
I also tried
It used to work before I ported the code to browserify. I'm using the following versions:
|
@vshulev, take a look at this gist https://gist.github.com/zaynetro/b575f0dc428bbbf9c810 . Example there works with out any troubles. |
@zaynetro, you're absolutely right! Tried your example, then tried the same thing I was trying yesterday and now it works without a problem... Not quite sure what the issue was, but closing the PR. Thanks for the gist! |
No description provided.