Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated to use new UMD suggestion #1762

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

EvanCarroll
Copy link

Fixed #1761

@acrobat acrobat added this to the 2.0.0 milestone Jan 20, 2016
@EvanCarroll
Copy link
Author

Can you create the 2.0 branch, mark this as status-completed (or whatever), and pull this so I can delete the repo?

@acrobat
Copy link
Member

acrobat commented Jan 28, 2016

I first going to release 1.6.0 this weekdn and then look if a 1.7 releases is needed otherwise I will create the 2.0 branch! If 1.7 is needed I will create a PR myself and use your commit. I will come back rto you about it this weekend!

@jblotus
Copy link

jblotus commented Nov 11, 2016

any progress on this?

@Azaret
Copy link
Contributor

Azaret commented Nov 11, 2016

As stated in the issue UMD will be postponed in 2.0 because I believe the new architecture of the plugin will be more suited for a better implementation.
As the PR itself, imo it should not be merged as far as there is unrelated commit in it like moving files around.

@vsn4ik vsn4ik self-requested a review May 21, 2019 07:15
@vsn4ik vsn4ik self-assigned this May 21, 2019
@vsn4ik vsn4ik removed their assignment Aug 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make conform to new UMD specification.
5 participants