Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed class .switch to .datepicker-switch #416

Merged
merged 10 commits into from
Apr 8, 2013
Merged

Renamed class .switch to .datepicker-switch #416

merged 10 commits into from
Apr 8, 2013

Conversation

t3chn0r
Copy link
Contributor

@t3chn0r t3chn0r commented Apr 2, 2013

Renamed class .switch used in Datepicker to .datepicker-switch as Bootstrap already has a class named .switch and it conflicts with Datepicker's rendering.

Screenshot courtesy of @michahell:
Snap 2013-04-02 at 07 39 07

@cgx
Copy link

cgx commented Apr 3, 2013

Yes, this fix is essential. 👍

eternicode added a commit that referenced this pull request Apr 8, 2013
Renamed class .switch to .datepicker-switch
@eternicode eternicode merged commit 5cdbe21 into uxsolutions:master Apr 8, 2013
@eternicode eternicode mentioned this pull request Apr 8, 2013
@CGollhardt
Copy link

Im new to git (used to subversion).

Is this now fixed? Because it is closed state?

For me it is conflicting with the class has-switch in combination with Bootstrap Switch:
https://github.com/nostalgiaz/bootstrap-switch

If i would do a Screenshot, it is the same as on top of this thread.

Edit:
Have found same on the other plugin:
Bttstrp/bootstrap-switch#70

@eternicode
Copy link
Contributor

@CGollhardt yes, this is in since the 1.1.0 release -- datepicker no longer uses the switch class, it uses the datepicker-switch class.

https://github.com/eternicode/bootstrap-datepicker/blob/1.1.3/js/bootstrap-datepicker.js#L1191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants