Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing user to manually input date #440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allowing user to manually input date #440

wants to merge 1 commit into from

Conversation

someyoungideas
Copy link

This allows the date to be set from the user manually inputing the date
into the input box. This had been discussed previously in an issue and was somewhat answered on a side note. The change is actually from another fork, but had never been actually a pull request. Recently we had used this feature and it worked wonderfully for the purpose we had in mind.

Here is the previous issue that was involved with this.

Issue #165

This allows the date to be set from the user manually inputing the date
into the input box.
@JoeDoyle23
Copy link

+1 We just got this bug come through on our project. This change worked like a charm.

@slafs
Copy link

slafs commented May 11, 2013

Hi! Even with this fix I can't seem to manage to edit an input box to change a date. Did you manage to fix this use case as well or is it normal that I can't do this?

@someyoungideas
Copy link
Author

What do you mean by "manage to edit". The scenarios we used this to cover was the ability to add a date manually with your keyboard. We still have full original functionality after this fix (using the mouse to click through the calendar). Are you using a specific browser possibly?

@slafs
Copy link

slafs commented May 14, 2013

I mean. I have a prepopulated field (as a component with data-date) with a date and it seems that I can't change it with keyboard only (or when i manage to do so I can't sync it with a datepicker).

@someyoungideas
Copy link
Author

I will check it out when I get some spare time and see if i can recreate it using the javascript from the sample on the readme. It has been working for me for a while now, and another has commented that it is working so I am not sure exactly where this is popping up at.

@slafs
Copy link

slafs commented May 14, 2013

I'll try to make some jsFiddle and maybe then it'll become clearer.

@someyoungideas
Copy link
Author

I took a look at this and was running over some different scenarios. From this jsfiddle everything I have changed is working as stated. The only time I was running into issues is if your initial input value is in a different format then what you place in the data-date-format. This shouldn't be an issue because that would be an error in code not for the user. Let me know if this fiddle is working for you or not. Thanks!

@slafs
Copy link

slafs commented May 16, 2013

Thanks for the fiddle. I managed to create my own which doesn't work http://jsfiddle.net/k4ug6/. I create some markup on the fly so maybe a made mistake somewhere. But basically the HTML it produces is the same as in this one http://jsfiddle.net/CrZx9/ which works well. Do you have any idea what can be wrong here?

@Schweinepriester
Copy link

+1

@itsalongstory
Copy link

Any update?

@itsalongstory
Copy link

2013 - 2021

@itsalongstory
Copy link

related to #2629

@cfarren
Copy link

cfarren commented Aug 18, 2021

I've just discovered this as well!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants