Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

z-index calculation should not stop at first element #710

Merged
merged 4 commits into from
Dec 15, 2014

Conversation

fadomire
Copy link
Contributor

i guess that when calculating proper z-index for the datepicker, we should find the max z-index value of parents() and not stop at first

related to #533 #170 #683 #678 #656 #665 #634 #621 #609 #464

@jezozwierzak
Copy link

I've seen some solution here:

http://stackoverflow.com/a/5680879/932965

Anyway I haven't had time to check if it have been optimal and set z-index manually.

@Yvem
Copy link

Yvem commented Apr 9, 2014

👍 See also #876

@Offirmo
Copy link

Offirmo commented Sep 8, 2014

Our production code is riddled with :

<div class="modal-dialog" style="z-index: 1050"> <!-- temporary fix for datepicker waiting for https://github.com/eternicode/bootstrap-datepicker/pull/710 -->

When will this issue (#569) be handled ?

@acrobat acrobat merged commit 262bb26 into uxsolutions:master Dec 15, 2014
acrobat added a commit that referenced this pull request Dec 15, 2014
@acrobat
Copy link
Member

acrobat commented Dec 15, 2014

Thanks @fadomire!

@Offirmo
Copy link

Offirmo commented Dec 16, 2014

gg @fadomire & @acrobat

@fadomire
Copy link
Contributor Author

thanks but #876 should have been merged instead of mine

@acrobat
Copy link
Member

acrobat commented Dec 17, 2014

@fadomire why do you think that? The solution in #876 wasn't compatible with <=IE9, so this PR looks like an more compatible fix to me

@fadomire
Copy link
Contributor Author

@acrobat #876 is basicly the same as mine, but cleaner and clearer to read.

But you are right for some IE version the map and slice method would crash, did not thought about that.

But maybe replacing the native map and slice in #876 with the jquery one would solve the cross browser issue while being clearer

@MillerRen
Copy link

thx

@Armstrongya
Copy link

@Offirmo Thanks for your solution, it works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants