Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concurrent request feature #96

Merged
merged 1 commit into from Feb 2, 2021
Merged

Add concurrent request feature #96

merged 1 commit into from Feb 2, 2021

Conversation

salos1982
Copy link

Allow more than pages count requests

uyamazak
uyamazak reviewed Feb 2, 2021
View reviewed changes
Copy link
Owner

@uyamazak uyamazak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, Thanks for your pull request.
It seems like a very smarter feature than it is now.

I'd like to fix the following minor warnings, is there a good way to do it?

test/plugins/hc-pages.test.ts#L4
't' is defined but never used

uyamazak
uyamazak reviewed Feb 2, 2021
View reviewed changes
src/plugins/hc-pages.ts
}

async destoroy(): Promise<void> {
async destroy(): Promise<void> {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@uyamazak
Copy link
Owner

uyamazak commented Feb 2, 2021

#96 (review)
It's a small matter. I'll handle it myself.

uyamazak
uyamazak approved these changes Feb 2, 2021
View reviewed changes
Copy link
Owner

@uyamazak uyamazak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uyamazak uyamazak merged commit fe9add2 into uyamazak:main Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uyamazak uyamazak uyamazak approved these changes

Assignees

@salos1982 salos1982

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@salos1982 @uyamazak