Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Banner changed to Beginner Wish after reset and pulling again on the same banner #17

Closed
yosaphatprs opened this issue Oct 23, 2020 · 3 comments · Fixed by #18
Closed

Banner changed to Beginner Wish after reset and pulling again on the same banner #17

yosaphatprs opened this issue Oct 23, 2020 · 3 comments · Fixed by #18

Comments

@yosaphatprs
Copy link

There is an issue when i was rolling on Klee's, Weapon and Standard Banner.
After doing roll, i was intended to reset the banner. Then, i proceed to rolling again on the same banner. I noticed that, the banner immediately changed to Beginner Wish.
@lauslim12
Copy link
Contributor

lauslim12 commented Oct 23, 2020 •
edited

Hello!

I have successfully replicated the bug. It seems that after we clicked the reset button and decided to roll again, the banner will return to Beginner's Wish, not the currently selected banner.

I will drop a patch soon in the form of a PR. Thank you for contributing!

@yosaphatprs
Copy link
Author

Glad to hear that, thanks for your hardwork!

@lauslim12 lauslim12 mentioned this issue Oct 23, 2020
Merged
@yosaphatprs
Copy link
Author

yosaphatprs commented Oct 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reset banner bug fix lauslim12-forks/genshin-impact-wish-simulator
2 participants
@lauslim12 @yosaphatprs