Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cbind's starting with a backslash (\) no longer work #251

Open
GSI opened this issue Apr 7, 2016 · 4 comments
Open

cbind's starting with a backslash (\) no longer work #251

GSI opened this issue Apr 7, 2016 · 4 comments

Comments

@GSI
Copy link
Contributor

GSI commented Apr 7, 2016

Please paste the output of uzbl-core --bug-info here:

Commit: v0.9.0-17-g5af1c22
GTK compile: 3.18.9
GTK run: 3.18.9
WebKit compile: 2.4.10
WebKit run: 2.4.10
WebKit2: 0
libsoup compile: 2.52.2
libsoup run: 2.52.2

With the default config, nothing happens upon typing \wiki.
@mathstuf
Copy link
Member

mathstuf commented Apr 7, 2016

Saw this as well on one machine, but hadn't tracked it down. I do have an older binary/config/EM which is working, so theres one place to bisect.

@keis
Copy link
Member

keis commented Apr 7, 2016

looks to be a case of escape inflation. a bind like \\\\wiki now works. So likely introduced by eccfa07

@mathstuf
Copy link
Member

mathstuf commented Apr 7, 2016

I wonder if something like @modmap "'" <Quote> wouldn't work here as well.

keis added a commit to keis/uzbl that referenced this issue Apr 8, 2016
@keis
Use default parse machinery for event command
bcc0cd9 
This allows us to send the data as quoted strings rather than pass them
through raw which has the side effect of dropping a level of escapes due
to the earlier pass done in uzbl-core.

Ref uzbl#251
@keis
Copy link
Member

keis commented Apr 8, 2016

Yeah. I guess that could work. But I would rather keep moving towards consistent parsing of stuff in uzbl. Any command with split=FALSE and all the places in the eventmanager that calls out to args.raw() is making things much harder than they need to be.

Doing something like bcc0cd9 should also fix this but has other issues. I dread to touch the parser of uzbl-core but if we could get rid of this bug that creates a lot of empty strings in the argument list I think it should just work (tm)

looks like this btw

ON_EVENT '' 'ESCAPE' '' '' '' 'event' 'KEYCMD_CLEAR'

keis added a commit to keis/uzbl that referenced this issue Apr 8, 2016
@keis
Use default parse machinery for event command
9be5b17 
This allows us to send the data as quoted strings rather than pass them
through raw which has the side effect of dropping a level of escapes due
to the earlier pass done in uzbl-core.

Ref uzbl#251
keis added a commit to keis/uzbl that referenced this issue Apr 8, 2016
@keis
Use default parse machinery for event command
4ae79b7 
This allows us to send the data as quoted strings rather than pass them
through raw which has the side effect of dropping a level of escapes due
to the earlier pass done in uzbl-core.

Update bind em plugin to use already quoted arguments

Ref uzbl#251
keis added a commit to keis/uzbl that referenced this issue Apr 8, 2016
@keis
Use default parse machinery for event command
23adbb9 
This allows us to send the data as quoted strings rather than pass them
through raw which has the side effect of dropping a level of escapes due
to the earlier pass done in uzbl-core.

Update bind and on_event plugins to use already quoted arguments.

Ref uzbl#251
keis added a commit to keis/uzbl that referenced this issue Apr 16, 2016
@keis
Use default parse machinery for event command
053caf1 
This allows us to send the data as quoted strings rather than pass them
through raw which has the side effect of dropping a level of escapes due
to the earlier pass done in uzbl-core.

Update bind and on_event plugins to use already quoted arguments.

Ref uzbl#251
keis added a commit to keis/uzbl that referenced this issue Apr 23, 2016
@keis
Use default parse machinery for event command
19c58dc 
This allows us to send the data as quoted strings rather than pass them
through raw which has the side effect of dropping a level of escapes due
to the earlier pass done in uzbl-core.

Update bind and on_event plugins to use already quoted arguments.

Ref uzbl#251
@keis keis mentioned this issue Jul 11, 2016
Merged
keis added a commit to keis/uzbl that referenced this issue Aug 1, 2016
@keis
Use default parse machinery for event command
ae689b0 
This allows us to send the data as quoted strings rather than pass them
through raw which has the side effect of dropping a level of escapes due
to the earlier pass done in uzbl-core.

Update bind and on_event plugins to use already quoted arguments.

Ref uzbl#251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mathstuf @keis @GSI