Handle partial writes in write_to_stream #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g_output_stream_write may also return without an error if only part of the buffer has been written. This may happen when there's not enough storage in the stream, for example when writing a lot of data (like long paths / URIs). g_output_stream_write_all however only returns either after successfully writing all of the buffer or after an IO error.
keis
approved these changes
Dec 28, 2017
mathstuf
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g_output_stream_writemay also return without an error if only part of the buffer has been written. This may happen when there's not enough storage in the stream, for example when writing a lot of data (like long paths / URIs).g_output_stream_write_allhowever only returns either after successfully writing all of the buffer or after an IO error.