fix: generate-sequential-string was allowing non-unique string

uzenith360 · Sep 16, 2023 · dd0092f · dd0092f
1 parent 1492866
commit dd0092f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/generate-sequential-string.ts b/src/generate-sequential-string.ts
@@ -12,6 +12,10 @@ export default (
     outputLength: number = 32,
     charset: string = '2346789ABCDEFHKLMNPQRTVWXY',
 ): string => {
+    if (new Set([...charset]).size !== charset.length) {
+        throw new Error('Character set must be unique');
+    }
+
     const charsetLength: number = charset.length;
     const output: string[] = [];
 

diff --git a/tests/generate-sequential-string.spec.ts b/tests/generate-sequential-string.spec.ts
@@ -18,6 +18,10 @@ describe('Generate sequential string', () => {
         assert.equal(next(), 'AAAABC');
         assert.equal(next(), 'AAAAB1');
     });
+
+    it('should throw error if character set is not unique', () => {
+        assert.throws(() => generateSequentialString(0, 0, '01234567890ABCDEFGHIJKLMNOPQRSTUVWXYZ'))
+    });
 });
 
 describe('Generate all combinations', () => {