Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken page transitions #116

Closed
yaslena opened this issue May 20, 2020 · 2 comments
Closed

Broken page transitions #116

yaslena opened this issue May 20, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@yaslena
Copy link
Collaborator

yaslena commented May 20, 2020

Currently, it is no longer possible to get working page transitions that contain page criteria in the test environment (bug?). All page transition criteria (visited page, completed exercise) are ignored and the transition buttons appear as if the criteria where not specified. The problem occurs in my storyline “lit-madness” (Managing Lunacy; on GitLab; for example chapter4/4.4.3 but also in chapters 2, 3 and 5) and to my knowledge also in “lit-feelingthepast” (for example here: chapter1/1.2.1/).
In my case, the transitions worked fine approximately one week ago (my game is offline so often, I cannot say precisely when the changes occured). Nothing was changed in those pages from my part.

The JSON for the page transition in chapter4/4.4.3 is set like this:

{ "id": null, "from": null, "to": "chapter4/4.4.4/page.json", "buttonText": "Yes, that must be the right chapter.", "time": { "time": 0 }, "money": { "amount": 0 }, "criteria": [ { "pageCriteria": null, "exerciseCriteria": "correctInput", "mailCriteria": null, "affectedExercise": "chapter4/4.4.3/radioButtonExercise1.json", "affectedPage": null, "affectedMail": null } ] }

The radioButtonExercise for the same page is set as follows:

{ "id": null, "numberOfColumns": 8, "offsetColumns": 2, "renderOrder": 3, "showInNotebook": false, "showInNotebookAt": "pageExit", "page": null, "exerciseState": null, "options": [ { "text": "Chapter 4", "correct": false }, { "text": "Chapter 5", "correct": true }, { "text": "Chapter 6", "correct": false } ] }

This page is still working in older versions of the game (old saves of unfinished game). Transition button is shown when correct answer is selected:

Screenshot_2020-05-19 Marugoto_TransitionOld1

Transition button is not shown when wrong answer is selected:

Screenshot_2020-05-19 Marugoto_TransitionOld2

In the latest version of the game, the transition button is always shown, regardless of any page criteria. Thus, no game choices matter any more.

@yaslena yaslena closed this as completed May 20, 2020
@yaslena
Copy link
Collaborator Author

yaslena commented May 24, 2020

It seems that most transitions are working again, but some are not. I have noticed that some transitions in lit-madness and in the trailer that have timers and an auto-transition feature don't work properly. In the trailer on page 1.1.7.1.2 there are two transition buttons displayed, when according to the page criteria there should be only one. In lit-madness on 4.5.15a the autotransition is never triggered after the timer runns out and the second transition (incorrectInput) never becomes available. However, I'm not sure if these problems are related.

@yaslena yaslena reopened this May 24, 2020
@yaslena yaslena closed this as completed May 25, 2020
@yaslena
Copy link
Collaborator Author

yaslena commented May 25, 2020

Here is a more detailed description of the error in the trailer:

On page 1.1.7.1.2 there are 2 transitions with the "visited" page criteria. You get Transition1 if you visited page 1.1.6.1B earlier:
{ "id": null, "from": null, "to": "trailer1/1.1.7.1.3B/page.json", "buttonText": "Call van Dijk back in to read your description", "time": { "time": 0 }, "money": { "amount": 0 }, "criteria": [ { "pageCriteria": "visited", "exerciseCriteria": null, "mailCriteria": null, "affectedExercise": null, "affectedPage": "trailer1/1.1.6.1B/page.json", "affectedMail": null } ] }

For Transition2 you need to have been on page 1.1.6.2notB:

{ "id": null, "from": null, "to": "trailer1/1.1.7.1.3notB/page.json", "buttonText": "Call van Dijk back in to read your description", "time": { "time": 0 }, "money": { "amount": 0 }, "criteria": [ { "pageCriteria": "visited", "exerciseCriteria": null, "mailCriteria": null, "affectedExercise": null, "affectedPage": "trailer1/1.1.6.2notB/page.json", "affectedMail": null } ] }

It is impossible to have been on both pages, they are not on the same path. If the game would work properly only one button would be displayed.

Nevertheless, when you come to this page the buttons of both transitions are displayed:
Trailer_twotransitions

There is also a timer (5 min) and the autotransition option on timer-expiration activated in the page.json:

{ "id": null, "title": "GLAMM Interview Test", "continueRandomly": false, "timerVisible": true, "autoTransitionOnTimerExpiration": true, "endOfTopic": false, "money": null, "time": { "time": 300 }, "chapter": null }

When the timer expires, it is always Transition1 which is triggered, regardless of the page criteria (visited A or B) defined in the transition pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants