-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with pageTransitions with criteria "visited" *and* time-settings #120
Comments
This a duplicate of #116 |
@Helena-LiT It's not quite a duplicate because the radioButtonExercise transition, which was also part of #116 , is fixed. |
should be fixed with 4ab23d1 |
Thanks so much, @nemtish we'll test it tomorrow. Best, Martin |
@martindusinberre The changes that presumably caused all these bugs were made at the same time and in the same instance (the trailer bug is not newer than the other transition bugs), so these two issues should be linked when people are looking for the cause of the problem. Adding a duplicate marker is just one way in GitHub to link two related issues, which makes sense when all of #120 is contained in #116. |
I would like to add some of my observations on the transition bug (autotransition + page criteria: visited) based on the Madness (Managing Lunacy storyline):
|
Setting aside these other transition issues for a moment: the original bug, which appears with a combination of "visited"/"notVisited" criteria in |
I don't have the same problem with the timer in the trailer. I have tested this page in firefox and edge browsers and I always get the correct 5min displayed. Maybe it's a browser problem (chrome?) or the problem is already solved. |
I think all of the above was already solved. |
OK, many thanks for pointing this out: has just worked for me fine in Firefox, too. What I experienced may be connected to #126 (I was testing many games consecutively) so for the time being, I'll close this assuming that this particular issue (combination of criteria + timer) is fixed. |
This is a problem that has emerged in the trailer. When we play it in the live system, everything works fine. In the test environment, however, the following problem occurs:
On page 1.1.7.1.2 there are 2
pageTransition.json
files; each have a "visited" criteria.pageTransition1.json
should appear if you visited page 1.1.6.1B earlier:{ "id": null, "from": null, "to": "trailer1/1.1.7.1.3B/page.json", "buttonText": "Call van Dijk back in to read your description", "time": { "time": 0 }, "money": { "amount": 0 }, "criteria": [ { "pageCriteria": "visited", "exerciseCriteria": null, "mailCriteria": null, "affectedExercise": null, "affectedPage": "trailer1/1.1.6.1B/page.json", "affectedMail": null } ] }
For
pageTransition2.json
you need to have been on page 1.1.6.2notB:{ "id": null, "from": null, "to": "trailer1/1.1.7.1.3notB/page.json", "buttonText": "Call van Dijk back in to read your description", "time": { "time": 0 }, "money": { "amount": 0 }, "criteria": [ { "pageCriteria": "visited", "exerciseCriteria": null, "mailCriteria": null, "affectedExercise": null, "affectedPage": "trailer1/1.1.6.2notB/page.json", "affectedMail": null } ] }
It is impossible to have been on both pages; but when the player arrives on 1.1.7.1.2, the buttonTexts of both transitions are incorrectly displayed:
![82829598-eb2ab280-9eb3-11ea-8325-b4a9275b3e9f](https://user-images.githubusercontent.com/53183999/82942770-c825fe80-9f98-11ea-8fc3-719f858d6bb4.png)
@Helena-LiT and I are at a loss to explain this: in Plantation Lives on the test environment, there are very similar pages (e.g. 2.1.8) and the transition works fine. The same is true of Madness.
The only thing we can hypothesize is that when there is a choice of pageTransition.json files and other elements such as the
autoTransitionOnTimerExpiration
(in thepage.json
file) set to "true" (with the time defined), then there is a problem. Moreover, on 1.1.7.1.2, when the timer expires, it is alwayspageTransition1.json
which is triggered, regardless of the page criteria (visited A or B) defined in the transition pages.These two elements--"visited" and "autoTransition"--are at play in the problematic 1.1.7.1.2 on the Trailer in the test environment. But this must be a new problem as it only occurs in the test environment and not on the live system.
@Helena-LiT also reports that in lit-madness on 4.5.15a the autotransition is never triggered after the timer runs out and the second transition (incorrectInput) never becomes available.
In other words: if the page transitions involve multiple elements (timer, visited/notVisited, correct/incorrect solutions), then a bug appears.
The text was updated successfully, but these errors were encountered: