-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove notebookVisible on page #39
Comments
I agree. Can we also update all of the json files once this has been done? (See new issue I've opened) |
ok. clean it up |
@martindusinberre let me know what should be removed/changed in JSON and I'll do it |
Unclear if this ever happened, but since unused I guess I can still remove from the JSON files... |
@martindusinberre this means, remove the entire true/false line for |
@interrogator yes, we've never used it, partly because the functionality of the notebook is now so much more sophisticated than we ever imagined. The only reason to have kept it would be to force the player to see something in the notebook, but I think we can do this with the content in a textComponent file now, so no worries. Plus, apparently the frontend isn't working anyway. So let's remove the entire line. |
I will remove it from the content, and then in the validator. I will just warn you that you need to pull once repos are updated :) |
If we do not need that, then we should remove it in backend.
Because in frontend thats not working.
Estimate for removing in backend: 1 hour.
The text was updated successfully, but these errors were encountered: