Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notebookVisible on page #39

Closed
christian-bernet opened this issue Aug 28, 2019 · 7 comments
Closed

Remove notebookVisible on page #39

christian-bernet opened this issue Aug 28, 2019 · 7 comments
Labels
enhancement Extending an existing feature medium medium priority

Comments

@christian-bernet
Copy link
Contributor

christian-bernet commented Aug 28, 2019

If we do not need that, then we should remove it in backend.
Because in frontend thats not working.
Estimate for removing in backend: 1 hour.

@martindusinberre
Copy link
Collaborator

I agree. Can we also update all of the json files once this has been done? (See new issue I've opened)

@christian-bernet
Copy link
Contributor Author

ok. clean it up

@interrogator
Copy link
Collaborator

@martindusinberre let me know what should be removed/changed in JSON and I'll do it

@martindusinberre martindusinberre added enhancement Extending an existing feature medium medium priority labels Sep 2, 2019
@christian-bernet christian-bernet removed their assignment Sep 3, 2019
@interrogator
Copy link
Collaborator

Unclear if this ever happened, but since unused I guess I can still remove from the JSON files...

@interrogator
Copy link
Collaborator

@martindusinberre this means, remove the entire true/false line for notebookVisible in page.json files? It does nothing?

@martindusinberre
Copy link
Collaborator

@interrogator yes, we've never used it, partly because the functionality of the notebook is now so much more sophisticated than we ever imagined. The only reason to have kept it would be to force the player to see something in the notebook, but I think we can do this with the content in a textComponent file now, so no worries. Plus, apparently the frontend isn't working anyway. So let's remove the entire line.
Is it then possible to update the validator so that the line is deleted from all files we currently have, so that nobody building from previous content accidentally deploys it?

@interrogator
Copy link
Collaborator

I will remove it from the content, and then in the validator. I will just warn you that you need to pull once repos are updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Extending an existing feature medium medium priority
Projects
None yet
Development

No branches or pull requests

3 participants