Skip to content

Commit

Permalink
Fixed issue Azure#8775 : Cannot create hybrid connection with disable…
Browse files Browse the repository at this point in the history
…d client authroization
  • Loading branch information
Ajit Navasare (MINDTREE LIMITED) committed Jul 10, 2019
1 parent 7c9db0b commit c268078
Show file tree
Hide file tree
Showing 7 changed files with 2,954 additions and 1,533 deletions.
5 changes: 5 additions & 0 deletions src/azure-cli/HISTORY.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,11 @@
Release History
===============

**Relay**

* Fixed issue #8775 : Cannot create hybrid connection with disabled client authroization
* Added parameter "--requires-transport-security" to az relay wcfrelay create

**Appservice**

* restore the idempotency of "appservice plan create" and "webapp create"
Expand Down
1 change: 1 addition & 0 deletions src/azure-cli/azure/cli/command_modules/relay/_params.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ def load_arguments_sb(self, _):
c.argument('status', arg_type=get_enum_type(['Active', 'Disabled', 'SendDisabled', 'ReceiveDisabled']), help='Enumerates the possible values for the status of a messaging entity.')
c.argument('relay_type', arg_type=get_enum_type(['Http', 'NetTcp']), default='NetTcp', help='Relay type')
c.argument('requires_client_authorization', arg_type=get_three_state_flag(), help='Indicates whether client authorization is required')
c.argument('requires_transport_security', arg_type=get_three_state_flag(), help='Indicates whether transport security is required')
c.argument('user_metadata', help='Endpoint metadata')

with self.argument_context('relay wcfrelay update') as c:
Expand Down
11 changes: 8 additions & 3 deletions src/azure-cli/azure/cli/command_modules/relay/custom.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ def cli_namespaceautho_update(instance, rights):

# WCF Relay Region
def cli_wcfrelay_create(client, resource_group_name, namespace_name, relay_name, relay_type,
requires_client_authorization=None, user_metadata=None):
requires_client_authorization=None, requires_transport_security=None, user_metadata=None):

from azure.mgmt.relay.models import WcfRelay, Relaytype

Expand All @@ -70,6 +70,7 @@ def cli_wcfrelay_create(client, resource_group_name, namespace_name, relay_name,
wcfrelay_params = WcfRelay(
relay_type=set_relay_type,
requires_client_authorization=requires_client_authorization,
requires_transport_security=requires_transport_security,
user_metadata=user_metadata
)

Expand All @@ -81,11 +82,12 @@ def cli_wcfrelay_create(client, resource_group_name, namespace_name, relay_name,


def cli_wcfrelay_update(instance, relay_type=None,
requires_client_authorization=None, user_metadata=None, status=None):
requires_client_authorization=None, requires_transport_security=None, user_metadata=None, status=None):

from azure.mgmt.relay.models import WcfRelay
returnobj = WcfRelay(relay_type=instance.relay_type,
requires_client_authorization=instance.requires_client_authorization,
requires_transport_security=instance.requires_transport_security,
user_metadata=instance.user_metadata)

if relay_type:
Expand All @@ -94,6 +96,9 @@ def cli_wcfrelay_update(instance, relay_type=None,
if requires_client_authorization:
returnobj.requires_client_authorization = requires_client_authorization

if requires_transport_security:
returnobj.requires_transport_security = requires_transport_security

if user_metadata:
returnobj.user_metadata = user_metadata

Expand All @@ -115,7 +120,7 @@ def cli_hyco_create(client, resource_group_name, namespace_name, hybrid_connecti
resource_group_name=resource_group_name,
namespace_name=namespace_name,
hybrid_connection_name=hybrid_connection_name,
parameters=hyco_params)
requires_client_authorization=requires_client_authorization, user_metadata=user_metadata )


def cli_hyco_update(instance, requires_client_authorization=None, status=None, user_metadata=None):
Expand Down
Loading

0 comments on commit c268078

Please sign in to comment.