Primitives, Variables, Operators and Mutability #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhonx
reviewed
Oct 5, 2019
vbrazo
reviewed
Oct 5, 2019
dhonx
requested changes
Oct 5, 2019
| @@ -23,5 +16,3 @@ fn main() { | |||
| /* println(foo) */ // Also wouldn't work because custom str func not defined . | |||
| @@ -30,7 +30,7 @@ If you don't want to use `\n` then you can use `println` instead. | |||
|
|
|||
| ## Comments | |||
|
|
|||
| V supports single line comments `//` and mutli line comments `/* */`. They should be used for documenting the code for letting the other users know how the code works. It can also be used for temporarly commenting the code which has to be used later on. | |||
| V supports single line comments `//` and mutli-line comments `/* */`. They should be used for documenting the code for letting the other users know how the code works. It can also be used for temporarily commenting the code which has to be used later on. | |||
There was a problem hiding this comment.
stay consistent with multi-line. change single line to single-line.
| @@ -0,0 +1,12 @@ | |||
| ## Keywords | |||
|
|
|||
| V is a very small language so it has less keywords. There are around 25 keywords. | |||
There was a problem hiding this comment.
maybe change less to fewer maybe better
There was a problem hiding this comment.
few would sound better imo.
vbrazo
changed the title
|
@Delta456 is it ready to merge? |
dhonx
approved these changes
Oct 6, 2019
|
@vbrazo It isn't |
|
@Delta456 i dont know... but some of my review is skipped... is up to you guys... i just review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will update the repo structure in one of next PRs.