Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: conditional statements like if, else, else if, for and while. #19

Merged
merged 18 commits into from
Oct 12, 2019
Merged

example: conditional statements like if, else, else if, for and while. #19

merged 18 commits into from
Oct 12, 2019

Conversation

vbrazo
Copy link
Member

@vbrazo vbrazo commented Oct 12, 2019 •
edited
Loading

This PR is related to #10.

@vbrazo vbrazo added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 12, 2019
@vbrazo vbrazo self-assigned this Oct 12, 2019
@vbrazo vbrazo changed the title Add if statement Add if statement example Oct 12, 2019
@Delta456
Copy link
Member

Delta456 commented Oct 12, 2019 •
edited
Loading

Why the name if_statement.md? Can't this simply be condtional_statement.md?

@Delta456
Copy link
Member

v_by_example/examples/conditional_statements/if_statement.md

Line 53 in 3924242

```v

We don't have markdown support for V yet. Use go.

@vbrazo
Copy link
Member Author

vbrazo commented Oct 12, 2019

@Delta456 renamed

@Delta456
Copy link
Member

Delta456 commented Oct 12, 2019 •
edited
Loading

v_by_example/examples/conditional_statements/if_statement.md

Line 18 in 3924242

```v

v_by_example/examples/conditional_statements/if_statement.md

Line 33 in 3924242

```v

Same here

@vbrazo vbrazo changed the title Add if statement example Add conditions example Oct 12, 2019
@vbrazo vbrazo changed the title Add conditions example - example: conditional statements like if, else, else if, for and while. Oct 12, 2019
@vbrazo vbrazo changed the title - example: conditional statements like if, else, else if, for and while. example: conditional statements like if, else, else if, for and while. Oct 12, 2019
@Delta456
Copy link
Member

I think a brief introduction to conditional statements would be good.

@Delta456
Copy link
Member

v_by_example/.gitignore

Line 20 in 58bca4b

.vrepl_temp.dSYM/Contents/Resources/DWARF/.vrepl_temp

Remove line 17 , 19 and 20

@vbrazo vbrazo force-pushed the add-if-statement-md branch 2 times, most recently from e5a5b34 to 2891f6e Compare October 12, 2019 12:11
@vbrazo vbrazo requested review from Delta456 and dhonx October 12, 2019 12:19
dhonx
dhonx approved these changes Oct 12, 2019
View reviewed changes
Copy link
Member

@dhonx dhonx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks Great for now !!! 👌

@vbrazo
Copy link
Member Author

vbrazo commented Oct 12, 2019

Thanks for reviewing! Merging for now and please feel free to open new PRs to improve this example.

@vbrazo vbrazo merged commit 7b0a364 into master Oct 12, 2019
@vbrazo vbrazo deleted the add-if-statement-md branch October 12, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhonx dhonx dhonx approved these changes

@Delta456 Delta456 Delta456 approved these changes

Assignees

@vbrazo vbrazo

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbrazo @Delta456 @dhonx